Re: mon_osd_nearfull_ratio (unchangeable) ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 26, 2016 at 09:37:37AM +0200, Dan van der Ster wrote:
> On Tue, Jul 26, 2016 at 3:52 AM, Brad Hubbard <bhubbard@xxxxxxxxxx> wrote:
> >> 1./ if I try to change mon_osd_nearfull_ratio from 0.85 to 0.90, I get
> >>
> >>    # ceph tell mon.* injectargs "--mon_osd_nearfull_ratio 0.90"
> >>    mon.rccephmon1: injectargs:mon_osd_nearfull_ratio = '0.9'
> >>    (unchangeable)
> >>    mon.rccephmon3: injectargs:mon_osd_nearfull_ratio = '0.9'
> >>    (unchangeable)
> >>    mon.rccephmon2: injectargs:mon_osd_nearfull_ratio = '0.9'
> >>    (unchangeable)
> >
> > This is telling you that this variable has no observers (i.e. nothing monitors
> > it dynamically) so changing it at runtime has no effect. IOW it is read at
> > start-up and not referred to again after that IIUC.
> 
> That's not actually true. In fact, the "unchangeable" feature is just
> misleading/wrong in most cases. See
> http://tracker.ceph.com/issues/16054
> 
> In this case, the config item is re-read for every new pgmap:
> 
> src/mon/PGMonitor.cc:    pending_inc.nearfull_ratio =
> g_conf->mon_osd_nearfull_ratio;
> 
> so it _is_ changeable at runtime.

Oh, I see now, my bad. That was a stupid mistake on my part since the code is
quite obvious. I was fooled by the code where "(unchangeable)" is output and
the commit/PR for that change.

Thanks for setting this straight and correcting my mistake.

> 
> -- Dan

-- 
Cheers,
Brad
_______________________________________________
ceph-users mailing list
ceph-users@xxxxxxxxxxxxxx
http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com



[Index of Archives]     [Information on CEPH]     [Linux Filesystem Development]     [Ceph Development]     [Ceph Large]     [Ceph Dev]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [xfs]


  Powered by Linux