Re: automatically closing stale pull requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Oct 2018, Patrick Donnelly wrote:
> On Thu, Oct 11, 2018 at 7:03 AM Sage Weil <sweil@xxxxxxxxxx> wrote:
> >
> > Should we enable a plugin like this?
> >
> >         https://github.com/probot/stale
> >
> > It will let you configure a period of inactivity before a PR gets a
> > message like
> >
> >           This issue has been automatically marked as stale because it has
> >           not had recent activity. It will be closed if no further
> >           activity occurs. Thank you for your contributions.
> >
> > and another period before the PR is closed.
> >
> > We have a bazillion stale open PRs.  :(
> >
> > My thinking is that ideally we really want something like this so tha
> > thte open PRs reflect a real work queue.  On the other hand, we also have
> > a big backlog of open PRs that have valid fixes (or, indirectly, bug
> > reports) that we probably need to go through and groom before
> > actually closing PRs.
> 
> There may also be issues in "Need Review" that need changed back to
> "New". For those that use Github has the SSOT for what needs reviewed,
> it could cause issues to become lost as I would think everyone
> frequently filters out "Need review" when searching for issues to
> fix/triage.

Unless/until we have some tool that tries to keep these in sync I think we 
have to rely on catching/checking these during the normal bug scrubs.  I 
think the auto-closing will be a longer interval (maybe ~2 months?), much 
less frequent than the bug scrubs when we should be noticing things that 
are "stuck" in Needs Review?

sage




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux