On Fri, Aug 18, 2017 at 8:12 PM, Abhishek Lekshmanan <abhishek@xxxxxxxx> wrote: > Amit <amitkuma@xxxxxxxxxx> writes: > >> Hello, >> >> I believe coding guidelines does not speak about this. >> >> But PR (https://github.com/ceph/ceph/pull/16705) talks on it. And its > ITYM it's here ;-) > >> still open. >> If we donot agree on contractions, Let's close it. >> >> Though "I am" instead of "I'm" -- both are completely correct English. >> But I read on PR, It suits more on ESL speakers and takes care of >> non-english speakers. >> >> I believe while reviewing the PRs, we can ask developers for changing >> "isn't" to "is not". [If we accept above PR?] >> Would be a step in including "Strong Phrases, Active voices" into >> documentation/Comments/std output.. no, i don't think we should enforce this. as this can be processed by script. and it *is*. instead of struggling with the use of contractions, IMHO, doc writers and reviewers need to focus on the content. > > Well there are enough comments on the PR itself supporting/opposing it, > however in the PR itself, John Wilkins mentions that if approved, it > would be mostly automated scripts that'd doing the cleanups and not an > imposition on the community itself to do anything special, and this > would be better rather than requesting changes from PR submitters > themselves. My stance on contractions themselves resonate Nathan's > comments on the PR, but I'd not oppose whatever documentation team > decides as it. > > However on code comments themselves I believe we shouldn't impose > anything, while typo fixes and obvious mistakes should be fixed, I think > it would be too much of an imposition if we expect every PR to confirm > to a contract of non contractions agreed. i think it does not make sense to be picky on the code comments unless there are typos and syntax errors which fail to convey the idea of the author and code. > > Best, > Abhishek > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, > HRB 21284 (AG Nürnberg) > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards Kefu Chai -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
