On Fri, Jul 29, 2016 at 11:22 AM, Vasu Kulkarni <vakulkar@xxxxxxxxxx> wrote:
> If we just have to worry about systemd it would be much simpler compared to
> supporting various previous initd systems(14.04/7.0 etc). changes can
> affect only jewel+ branches.
Right, the Upstart stuff for Trusty would be a sticking point, but I'm
not too worried about that for now, since this is a ways' off.
Everybody should be moving to Jessie and Xenial, right? :)
> I still see some challenges here, some of the code in ceph_manager.py
> does pretty fast killing and revive of osd's, I think that would be possible
> with systemd and also generally KILL of process wont work since systemd
> will end up restart the process based on its config, So those cases have
> to be rewritten.
That's a good point about systemd automatically restarting the
daemons, that will need more scrutiny.
I see ceph_manager.py doing stuff like:
self.ctx.daemons.get_daemon('osd', osd, self.cluster).stop()
and from teuthology/orchestra/daemon.py , the "stop()" method there
just calls close() on the daemon's stdin. From what Josh said, stdin
is simply there to keep the daemon alive for the duration of the test,
so this ceph_manager.py code is effectively like sending a TERM or
KILL signal.
In other words, I think there's no relevant difference between what
ceph_manager.py does to kill daemons today, and what "systemctl stop
ceph-osd@..." would do? That would solve the automatic restart
concern.
- Ken
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
