Thanks, I think, it works: https://github.com/ceph/ceph/pull/10066 ------------------------------- Best regards, Alyona Kiseleva On Thu, Jun 30, 2016 at 5:31 PM, Sage Weil <sweil@xxxxxxxxxx> wrote: > On Thu, 30 Jun 2016, Alyona Kiselyova wrote: >> So, if I'm right, we need now a submodule, which is a fork of isa-l >> repo: https://github.com/01org/isa-l >> And then I'll can use it in my code, shown above, instead of copy of >> isa-l files, as I do it now, and problem with asm files compilation >> I'll solve via make and cmake files. Also this can be done in >> erasure-code plugin. >> In this case, who can help me with submodule creation? What procedure >> is needed here? Thanks! > > I made a fork for the ceph github user at > > https://github.com/ceph/isa-l > > Use that as the remote and create a branch that adds it as a submodule at > src/isa-l. 'git submodule add ...'. That should do it! > > sage > > >> ------------------------------- >> Best regards, >> Alyona Kiseleva >> >> >> On Tue, Jun 28, 2016 at 10:38 PM, Ali Maredia <amaredia@xxxxxxxxxx> wrote: >> > Alyona & Sage, >> > >> > I'm a little unclear on what wants to be accomplished. >> > >> > From what I understand we would add a new submodule, which is a fork of the original, that has the asm files renamed to asm.s. >> > >> > Would we need to make ISA-L build with CMake? >> > >> > That being said CMake should be able to handle it without any issues. >> > >> > I'd be glad to help out with any CMake the integration process/issues/questions for the new submodule. >> > >> > -Ali >> > >> > ----- Original Message ----- >> > From: "Sage Weil" <sage@xxxxxxxxxxxx> >> > To: "Alyona Kiselyova" <akiselyova@xxxxxxxxxxxx> >> > Cc: "Haomai Wang" <haomai@xxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx >> > Sent: Tuesday, June 28, 2016 10:17:31 AM >> > Subject: Re: How to propose plugin, which uses external lib >> > >> > On Tue, 28 Jun 2016, Alyona Kiselyova wrote: >> >> In this case I would like to propose isa-l extension for zlib plugin - >> >> https://github.com/ceph/ceph/compare/master...Ved-vampir:zlib_isal_extension?expand=1 >> >> I think, it would be better to choose plugin type based on processor >> >> type, this variant is used in branch. To add tuned option on the step >> >> of plugin loading is possible too, but here we can get an assert in >> >> case, if processor type is not compatible. Or it will be better >> >> nevertheless to keep this option and leave error treatment for plugin >> >> user? >> > >> > You mean in the case where the user set zlib_use_isal=true but the >> > processor doesn't have the right features? In that case we could just >> > ignore the option and fall back. >> > >> > But what you have here looks fine to me. >> > >> > Could you perhaps add a unit test that takes some random data >> > (/dev/urandom maybe?) and compresses without isal and decompressed >> > with, and the other way around, so we have confidence they are >> > bit-compatible? >> > >> >> About isa-l lib files. The only change, that I made to them, is >> >> renaming asm files to asm.s, but I suspect this restriction can be >> >> bypassed by some options in make/cmake files? In this way I think it >> >> would be better to create submodule repo for isa-l lib, because I'm >> >> still thinking, that just making a copy is not a very good way. >> > >> > Yeah, I'm happy to go the submodule route. I expect making cmake handle >> > it is doable... Ali? >> > >> > sage >> > >> > >> > >> >> ------------------------------- >> >> Best regards, >> >> Alyona Kiseleva >> >> >> >> >> >> On Fri, Jun 17, 2016 at 7:47 PM, Sage Weil <sage@xxxxxxxxxxxx> wrote: >> >> > On Sat, 18 Jun 2016, Haomai Wang wrote: >> >> >> Cool, I guess it should be behavior better than others in intel platform. >> >> >> >> >> >> On Fri, Jun 17, 2016 at 11:51 PM, Alyona Kiselyova >> >> >> <akiselyova@xxxxxxxxxxxx> wrote: >> >> >> > Hi, >> >> >> > I would like to propose a new compression plugin, which is based on >> >> >> > Isa-l open source library >> >> >> > (https://github.com/01org/isa-l/tree/master/igzip). I already have a >> >> >> > code - https://github.com/Ved-vampir/ceph/tree/wip_isal_plugin/src/compressor/isal. >> >> >> > I see, that there are erasure-code plugin, based on isa-l too. As I >> >> >> > see, library code is not loaded as submodule repo, like some others. >> >> > >> >> > In this case, I assume the inflate/deflate encoding is compatible with >> >> > zlib. If that's the case, I think we don't want to treat this as a >> >> > different compression type, but rather as an optimized >> >> > implementation of the same type. >> >> > >> >> > Not sure the best way to do that, though. The simplest would probably be >> >> > to make the ZlibCompressor either use zlib or isal based on an option >> >> > and/or processor type. >> >> > >> >> >> > But if I'm right, I think, it's not the best way to use external code. >> >> >> >> >> >> Sorry, why it's not a best way? >> >> >> >> >> >> > The question is, what is the right way to use external library in my case? >> >> >> >> >> >> I think maybe we could make the whole >> >> >> repo(https://github.com/01org/isa-l) as submodule and make each dir >> >> >> used by different compoent? >> >> > >> >> > In the crc case we just copied the relevant asm files into the ceph repo. >> >> > That's probably not the best path, though. I think we had to make some >> >> > minor changes to make them build, too. :/ >> >> > >> >> > sage >> >> -- >> >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> >> >> > -- >> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> > the body of a message to majordomo@xxxxxxxxxxxxxxx >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
