Hi Willem, Agree. The c++ notations and our declarations using them do centralize all this. I don't know if we're actually defining anything equivalent to the coarse/fast clocks (it seems like a good idea, and I assumed we would), and it's straightforward to do. (Adam may have, already.) Matt ----- Original Message ----- > From: "Willem Jan Withagen" <wjw@xxxxxxxxxxx> > To: "Erwan Velu" <evelu@xxxxxxxxxx>, "Adam C. Emerson" <aemerson@xxxxxxxxxx> > Cc: "Sage Weil" <sweil@xxxxxxxxxx>, "The Sacred Order of the Squid Cybernetic" <ceph-devel@xxxxxxxxxxxxxxx> > Sent: Saturday, January 23, 2016 6:49:21 AM > Subject: Re: About ceph_clock_now() > > On 22-1-2016 17:00, Erwan Velu wrote: > > Hey, > > > > I've been able to continue this work and updated by branch accordingly. > > I understand the benefit of using the ceph_time work but I feel that it > > makes the change pretty verbose for a not a so big change (CLOCK_REALTIME > > vs CLOCK_MONO). > > > > This imply a change of all utime_t and makes the computations a little bit > > more complex to read. > > > > Does it worth the time spent on it ? If yes, I don't have any issue > > continuing this way. > > I'm pretty new to the project and would like to make the best PR as > > possible. > > So your insights on the under-work patch would be very helpful. > > Erwan, > > It would be real useful if references to CLOCK_(MONOTONIC|REALTIME)_* > are centralised in one place (or at least as little as possible). > And perhaps wrapped in simple function. > > Reason is that CLOCK_*_COARSE are linux specific. > > POSIX only has CLOCK_*, without the COARSE. > FreeBSD has the CLOCK_*_FAST variant which equals the COARSE objective. > (less accuracy, more speed) > > So I've wrapped the code in a > #if defined(__linux__) > # USE the COARSE variant > #elif defined(__FreeBSD__) > # USE the FAST variant > #else > # Use the POSIX version as fallback > #endif > > Thanx, > --WjW > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-707-0660 fax. 734-769-8938 cel. 734-216-5309 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
