Hey, I've been able to continue this work and updated by branch accordingly. I understand the benefit of using the ceph_time work but I feel that it makes the change pretty verbose for a not a so big change (CLOCK_REALTIME vs CLOCK_MONO). This imply a change of all utime_t and makes the computations a little bit more complex to read. Does it worth the time spent on it ? If yes, I don't have any issue continuing this way. I'm pretty new to the project and would like to make the best PR as possible. So your insights on the under-work patch would be very helpful. https://github.com/ErwanAliasr1/ceph/tree/evelu-monotonic Thanks, ----- Mail original ----- De: "Erwan Velu" <evelu@xxxxxxxxxx> À: "Adam C. Emerson" <aemerson@xxxxxxxxxx> Cc: "Sage Weil" <sweil@xxxxxxxxxx>, "The Sacred Order of the Squid Cybernetic" <ceph-devel@xxxxxxxxxxxxxxx> Envoyé: Jeudi 21 Janvier 2016 20:22:56 Objet: Re: About ceph_clock_now() Hi, I'm sadly not at full time on Ceph but you can find my work in progress on this PR in my personal branch. I'm thinking of making a single commit explaining this change and propagating it to the whole codebase: https://github.com/ErwanAliasr1/ceph/commit/00daa403831c9e0dfffb6f31a48723ca3cc3b569 Note this is WIP and I'm currently hiting obvious places where ceph_clock_now() can be replaced. I don't know a lot about the coebase so I'll ask my questions later about the locations where I have doubts. Cheers, Erwan ----- Mail original ----- De: "Adam C. Emerson" <aemerson@xxxxxxxxxx> À: "Erwan Velu" <evelu@xxxxxxxxxx> Cc: "Sage Weil" <sweil@xxxxxxxxxx>, "The Sacred Order of the Squid Cybernetic" <ceph-devel@xxxxxxxxxxxxxxx> Envoyé: Mardi 19 Janvier 2016 17:29:03 Objet: Re: About ceph_clock_now() On 19/01/2016, Erwan Velu wrote: > Before propagating the change to more code base and offer a PR with that, what do you think of this style ? > > Is it aligned with the best-pratices of the project ? > > https://gist.github.com/ErwanAliasr1/f74f7f046e9300ac2c30 One minor thing, you shouldn't use anything in time_detail directly. It SHOULD be ceph::coarse_mono_clock::now() ('detail' or leading underscores signal a 'private' namespace.) Other than that, this looks very good. -- Senior Software Engineer Red Hat Storage, Ann Arbor, MI, US IRC: Aemerson@{RedHat, OFTC, Freenode} 0x80F7544B90EDBFB9 E707 86BA 0C1B 62CC 152C 7C12 80F7 544B 90ED BFB9 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
