On 19/01/2016, Erwan Velu wrote: > Before propagating the change to more code base and offer a PR with that, what do you think of this style ? > > Is it aligned with the best-pratices of the project ? > > https://gist.github.com/ErwanAliasr1/f74f7f046e9300ac2c30 One minor thing, you shouldn't use anything in time_detail directly. It SHOULD be ceph::coarse_mono_clock::now() ('detail' or leading underscores signal a 'private' namespace.) Other than that, this looks very good. -- Senior Software Engineer Red Hat Storage, Ann Arbor, MI, US IRC: Aemerson@{RedHat, OFTC, Freenode} 0x80F7544B90EDBFB9 E707 86BA 0C1B 62CC 152C 7C12 80F7 544B 90ED BFB9
Attachment:
signature.asc
Description: PGP signature
