On 8-12-2015 13:36, Mykola Golub wrote:
On Tue, Dec 08, 2015 at 11:04:13AM +0100, Willem Jan Withagen wrote:
On 4-12-2015 21:11, Willem Jan Withagen wrote:
One larger problem with libraries I have is the stuff with dlopen.
In ./configure it seems that most of the code is short-circuited, and -ldl
gets appended in the Makefile.am's by default. The code there is rather hard
to parse.
FreeBSD has this in libc, so no specific includes needed.
Now the question is how do I cleanly fix this without breaking just
about every other platform?
Could you provide particular examples? Because what I see in the
master is usually like below:
if LINUX
xio_server_LDADD += -ldl
endif
If you see somewhere -ldl is added unconditionally it is likely to
have to be fixed the same way.
Several of the test makefiles did not have this.
For this I've patched at least:
src/tools/Makefile-server.am
src/tracing/Makefile.am
src/erasure-code/Makefile.am
src/rgw/Makefile.am
And this is indeed what I've added ATM to get my tests compiled.
But I really wonder if this is the way to go, instead of fixing it
in configure and be done with it. Just like wiht most of the other
libraries that are setup thru automake/configure. That would also
help other ports, then for that port one does not have to augment
again all locations.
AND if new tests would be written, we do not have to check if all
exempts are correctly covered.
--WjW
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
