> In this case the commands look a little confusing to me, as from their > names I would rather think they enable/disable mirror for existent > images too. Also, I don't see a command to check what current > behaviour is. And, I suppose it would be useful if we could configure > other default features for a pool (exclusive-lock, object-map, ...) > Also, I am not sure we should specify <pool-name> this way, as it is > not consistent with other rbd commands. By default rbd operates on > 'rbd' pool, which can be changed by --pool option. So what do you > think if we have something similar to 'rbd feature' commands? > > rbd [--pool <pool>] default-feature enable <feature> > rbd [--pool <pool>] default-feature disable <feature> > rbd [--pool <pool>] default-feature show [<feature>] > > (If <feature> is not specified in the last command, all features are > shown). > > Similarly, it might be useful to have 'rbd feature show' command: > > rbd feature show <image-spec> [<feature>] > > BTW, where do you think these default feature flags will be stored? > Storing in pg_pool_t::flags I suppose is the easiest but it looks like > a layering violation. > I used 'mirror pool enable/disable' to keep all the related commands together. I wasn't attempting to create a mechanism to specify arbitrary default features for a given pool, only the ability to enable mirroring (by default) on a given pool since that is the use case discussed at CDS. Image features can already be seen (along with lots of other image stats) via "rbd info <image-spec>". Mirror pool settings can be seen via the previously proposed "mirror pool info" command. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
