On Wed, Sep 2, 2015 at 5:22 AM, Yan, Zheng <zyan@xxxxxxxxxx> wrote: > timespec_to_jiffies() does not work this way. it convert time delta in form of timespec to time delta in form of jiffies. Ah sorry, con->last_keepalive_ack is a realtime timespec from userspace. > > I will updated the patch according to the rest comments . I still want ceph_con_keepalive_expired() to handle interval == 0 internally, so that opt->monc_ping_timeout can be passed without any checks in the caller. I also noticed you added delay = max_t(unsigned long, delay, HZ); to __schedule_delayed(). Is it really necessary? Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html