On Thu, Jan 22, 2015 at 4:33 PM, Chaitanya Huilgol
<Chaitanya.Huilgol@xxxxxxxxxxx> wrote:
> Ok, I think for now we should first get the core feature support in, if the changes in the messenger layer look fine, then I will generate two patches
> - messenger specific options
> - tcp_nodelay support
>
> As a next set we can implement the krbd_default_map_options in the ceph.conf and pass it down.
>
> Let me know.
Honestly, I don't see the point of splitting options the way you did
either. There is just too much boilerplate for something as simple as
couple of flags: a struct with a single field to which ceph_messenger
then has a pointer, all the msgr opt macros (why?), the fact that
libceph options are now split between libceph.h and messenger.h, etc.
I'd just pass struct ceph_options * to ceph_messenger_init() and be
done with it.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
