Ok, I think for now we should first get the core feature support in, if the changes in the messenger layer look fine, then I will generate two patches - messenger specific options - tcp_nodelay support As a next set we can implement the krbd_default_map_options in the ceph.conf and pass it down. Let me know. Regards, Chaitanya -----Original Message----- From: Ilya Dryomov [mailto:ilya.dryomov@xxxxxxxxxxx] Sent: Thursday, January 22, 2015 6:20 PM To: Chaitanya Huilgol Cc: Somnath Roy; Sage Weil; Chaitanya Huilgol; Ceph Development Subject: Re: [PATCH] ceph: rbd option listing and tcp_nodelay support On Thu, Jan 22, 2015 at 12:54 PM, Chaitanya Huilgol <Chaitanya.Huilgol@xxxxxxxxxxx> wrote: > Hi Ilya, > > We have two options here, > (1) Have kernel export supported options and pass on supported options > from ceph.conf automatically if user has not specified the same via > rbd -o - this is what is done in the current patch Or > (2) As suggested by you, Have a default map options in ceph.conf and > pass all options which have not be overridden by rbd -o > > As I understand, there is no need to do both - we need to choose between the two. > After your suggestion, I am leaning towards option-2 as it give more > krbd specific control. However, the onus now rests on the user to add > default options based on what the kernel supports (for this we can > still provide the options listing via the sysbus interface, say with > 'rbd map supported_options' cli) And the question then is: do we really need this supported_options cli? rbd map options are treated very much like filesystem mount options - the set of supported options is determined by the kernel version and is documented in rbd(8) man page. (There aren't any kernel version details in there currently, but that's simply because all existing options have been added in bulk a long time ago, and we can fix that omission with the addition of tcp_nodelay.) Thanks, Ilya ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). ��.n��������+%������w��{.n����z��u���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
