On Wed, Jan 21, 2015 at 10:00 PM, Chaitanya Huilgol
<chaitanya.huilgol@xxxxxxxxx> wrote:
> From: Chaitanya Huilgol <chaitanya.huilgol@xxxxxxxxxxx>
>
> Option keys supported by libceph and rbd modules is readable
> as a comma separated string via /sys/bus/rbd/options read-only
> interface. This will allow user app (rbd cli) to check for
> supported option keys before passing options to the kernel and
> remain compatible with older kernels which do not support a
> particular feature.
> Messenger specific options moved to messenger layer.
> tcp_nodelay(default)/no_tcp_nodelay option added for setting
> TCP_NODELAY on messenger socket connections. Covers both rbd
> and cephfs
Hi Chaitanya,
Just couple high level comments - I'll take a closer look tomorrow.
Option listing and tcp_nodelay should be two separate patches
rbd: add option sysfs attiribute
libceph: add tcp_nodelay option
or something like that. The "Messenger specific options moved to
messenger layer" part should probably be a separate patch as well.
More importantly, I'm missing the whole point of exporting supported
rbd options. Adding a new libceph option does not break compatibility
in either way, as old kernels will simply fail to map/mount if a bad
(unknown, let through by new rbd cli) option is encountered.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
