Hi James, I just wanted to follow up on this thread. I’d like to bring this patch into the wip-port portability branch. Were you able to get the boost::uuid to work as a drop-in replacement? Thanks, Noah On Nov 9, 2013, at 9:22 PM, Sage Weil <sage@xxxxxxxxxxx> wrote: > On Sun, 10 Nov 2013, James Harper wrote: >>> >>> On Sat, 9 Nov 2013, James Harper wrote: >>>> Just out of curiosity (recent thread about windows port) I just had a >>>> quick go at compiling librados under mingw (win32 cross compile), and >>>> one of the errors that popped up was the lack of libuuid under mingw. >>>> Ceph appears to use libuuid, but I notice boost appears to include a >>>> uuid class too, and it seems that ceph already uses some of boost (which >>>> already builds under mingw). >>>> >>>> Is there anything special about libuuid that would mean boost's uuid >>>> class couldn't replace it? And would it be better to still use ceph's >>>> uuid.h as a wrapper around the boost uuid class, or to modify ceph to >>>> use the boost uuid class directly? >>> >>> Nice! Boost uuid looks like it would work just fine. It is probably >>> easier and less disruptive to use it from within the existing class in >>> include/uuid.h. >>> >> >> That seems to work (the header compiles at least), but then it falls >> down when things try to memcpy out of it. In particular, an fsid appears >> to be a char[16]. Is that a uuid? And is keeping it as a byte array an >> optimisation? > > Probably just being lazy; where was that? Feel free to replace the memcpy > with methods to copy in/out if it's necessary... > > sage > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
