Reviewed-by: Sage Weil <sage@xxxxxxxxxxx>
On Thu, 13 Dec 2012, Alex Elder wrote:
> In __unregister_linger_request(), the request is being removed
> from the osd client's req_linger list only when the request
> has a non-null osd pointer. It should be done whether or not
> the request currently has an osd.
>
> This is most likely a non-issue because I believe the request
> will always have an osd when this function is called.
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
> ---
> net/ceph/osd_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 470816c..b15b475 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -907,8 +907,8 @@ static void __unregister_linger_request(struct
> ceph_osd_client *osdc,
> struct ceph_osd_request *req)
> {
> dout("__unregister_linger_request %p\n", req);
> + list_del_init(&req->r_linger_item);
> if (req->r_osd) {
> - list_del_init(&req->r_linger_item);
> list_del_init(&req->r_linger_osd);
>
> if (list_empty(&req->r_osd->o_requests) &&
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
