Reviewed-by: Sage Weil <sage@xxxxxxxxxxx>
On Fri, 14 Dec 2012, Alex Elder wrote:
> When a connection's socket disconnects, or if there's a protocol
> error of some kind on the connection, a fault is signaled and
> the connection is reset (closed and reopened, basically). We
> currently get an error message on the log whenever this occurs.
>
> A ceph connection will attempt to reestablish a socket connection
> repeatedly if a fault occurs. This means that these error messages
> will get repeatedly added to the log, which is undesirable.
>
> Change the error message to be a warning, so they don't get
> logged by default.
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
> ---
> net/ceph/messenger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index 4b04ccc..4d111fd 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -2377,7 +2377,7 @@ fault:
> static void ceph_fault(struct ceph_connection *con)
> __releases(con->mutex)
> {
> - pr_err("%s%lld %s %s\n", ENTITY_NAME(con->peer_name),
> + pr_warning("%s%lld %s %s\n", ENTITY_NAME(con->peer_name),
> ceph_pr_addr(&con->peer_addr.in_addr), con->error_msg);
> dout("fault %p state %lu to peer %s\n",
> con, con->state, ceph_pr_addr(&con->peer_addr.in_addr));
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
