Re: [PATCH 7/9] rbd: don't use ENOTSUPP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Sage Weil <sage@xxxxxxxxxxx>

On Thu, 13 Dec 2012, Alex Elder wrote:

> ENOTSUPP is not a standard errno (it shows up as "Unknown error 524"
> in an error message).  This is what was getting produced when the
> the local rbd code does not implement features required by a
> discovered rbd image.
> 
> Change the error code returned in this case to ENXIO.
> 
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
> ---
>  drivers/block/rbd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index ce26b749..4daa400 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2456,7 +2456,7 @@ static int _rbd_dev_v2_snap_features(struct
> rbd_device *rbd_dev, u64 snap_id,
> 
>  	incompat = le64_to_cpu(features_buf.incompat);
>  	if (incompat & ~RBD_FEATURES_ALL)
> -		return -ENOTSUPP;
> +		return -ENXIO;
> 
>  	*snap_features = le64_to_cpu(features_buf.features);
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux