On Fri, Sep 15, 2023 at 08:38:51AM +0000, Jose Abreu wrote: > From: Serge Semin <fancer.lancer@xxxxxxxxx> > Date: Thu, Sep 14, 2023 at 18:05:09 > > > I actually thought the driver has been long abandoned seeing how many > > questionable changes have been accepted. That's why I decided to step > > in with more detailed reviews for now. Anyway It's up to you to > > decide. You are the driver maintainer after all. > > It's up to everyone to decide. I understand your comments on the patchset > and agree with most of them Ok. Thanks for clarification. I'll keep reviewing the bits then submitted for the STMMAC driver based on my knowledges of the driver guts and the DW GMAC/XGMAC/Eth QoS IP-cores implementation. > but on the topic of changing the entire > patchset to add the fix on "plat_stmmacenet_data->fix_mac_speed", > I don't think it's on the scope of this series. That's what I meant in my comment. Of course it's out of the series scope. -Serge(y) > > Thanks, > Jose