Russel, Jose On Thu, Sep 14, 2023 at 04:01:41PM +0000, Jose Abreu wrote: > From: Russell King (Oracle) <linux@xxxxxxxxxxxxxxx> > Date: Thu, Sep 14, 2023 at 16:30:11 > > > On Thu, Sep 14, 2023 at 04:27:19PM +0100, Russell King (Oracle) wrote: > > > I won't be doing that, sorry. If that's not acceptable, then I'm > > > junking this series. > > > > In fact, no, I'm making that decision now. I have 42 patches. I'm > > deleting them all because I just can't be bothered with the hassle > > of trying to improve this crappy driver. I am sorry to read that. In no means I intended to cause such reaction, but merely to improve the suggested changes as I see it. Speaking about the stmmac driver. I've got over _200_ cleanup, fix and feature patches in my local repo waiting for me having a free time to be properly prepared and finally submitted for review. So I totally understand your initial desire to improve the driver code. > > Hi Russell, Serge, Jakub, > > My apologies for not being that active on the review. I totally understand > there's a lot of revamps needed on "stmmac", somethings may even > need to be totally re-written. > > I'm also aware that Russell has contributed significantly for this process > and was of great help when we first switched "stmmac" to phylink. > > So, my 5-cents here is that, on this stage, any contribution on > "stmmac" is welcomed and we shouldn't try to ask for more > but focus instead on small steps. I actually thought the driver has been long abandoned seeing how many questionable changes have been accepted. That's why I decided to step in with more detailed reviews for now. Anyway It's up to you to decide. You are the driver maintainer after all. -Serge(y) > > Thanks, > Jose
