On Fri, May 5, 2023 at 2:59 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> Some netdevices may get unregistered before late_initcall(),
> we have to move the hashtable init earlier.
>
> Fixes: f1fc43d03946 ("bpf: Move offload initialization into late_initcall")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217399
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
Make sense, thank you!
> ---
> CC: ast@xxxxxxxxxx
> CC: daniel@xxxxxxxxxxxxx
> CC: andrii@xxxxxxxxxx
> CC: martin.lau@xxxxxxxxx
> CC: song@xxxxxxxxxx
> CC: yhs@xxxxxx
> CC: john.fastabend@xxxxxxxxx
> CC: kpsingh@xxxxxxxxxx
> CC: sdf@xxxxxxxxxx
> CC: haoluo@xxxxxxxxxx
> CC: jolsa@xxxxxxxxxx
> CC: bpf@xxxxxxxxxxxxxxx
> ---
> kernel/bpf/offload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
> index d9c9f45e3529..8a26cd8814c1 100644
> --- a/kernel/bpf/offload.c
> +++ b/kernel/bpf/offload.c
> @@ -859,4 +859,4 @@ static int __init bpf_offload_init(void)
> return rhashtable_init(&offdevs, &offdevs_params);
> }
>
> -late_initcall(bpf_offload_init);
> +core_initcall(bpf_offload_init);
> --
> 2.40.1
>
