On 5/4/23 11:43 AM, Stanislav Fomichev wrote:
optval larger than PAGE_SIZE leads to EFAULT if the BPF program isn't careful enough. This is often overlooked and might break completely unrelated socket options. Instead of EFAULT, let's ignore BPF program buffer changes. See the first patch for more info. In addition, clearly document this corner case and reset optlen in our selftests (in case somebody copy-pastes from them).
Looks good. A respin is needed to address the selftest issues. The bpf CI will help to confirm that.
Looking forward to v5. Thanks.