On Thu, 16 Jun 2022 18:00:40 +0200 Maciej Fijalkowski wrote: > > Loopback or not, I don't think we should be accepting the shutdown -> > > set config -> pray approach in modern drivers. ice_open() seems to be > > allocating all the Rx memory, and can fail. > > They say that those who sing pray twice, so why don't we sing? :) > > But seriously, I'll degrade this to ice_down/up and check retvals. I think > I just mimicked flow from ice_self_test(), which should be fixed as > well... > > I'll send v4. checking retval is not enough, does ice not have the ability to allocate resources upfront? I think iavf was already restructured to follow the "resilient" paradigm, time for ice to follow suit? This is something DaveM complained about in the first Ethernet driver I upstreamed, which must have been a decade ago by now. It's time we all get on board :)
