On Wed, Jun 15, 2022 at 04:47:40PM -0700, Jakub Kicinski wrote: > On Tue, 14 Jun 2022 19:47:40 +0200 Maciej Fijalkowski wrote: > > + if (if_running) > > + ice_stop(netdev); > > + if (ice_aq_set_mac_loopback(&pf->hw, ena, NULL)) > > + dev_err(ice_pf_to_dev(pf), "Failed to toggle loopback state\n"); > > + if (if_running) > > + ice_open(netdev); > > Loopback or not, I don't think we should be accepting the shutdown -> > set config -> pray approach in modern drivers. ice_open() seems to be > allocating all the Rx memory, and can fail. They say that those who sing pray twice, so why don't we sing? :) But seriously, I'll degrade this to ice_down/up and check retvals. I think I just mimicked flow from ice_self_test(), which should be fixed as well... I'll send v4.
