On Tue, 14 Jun 2022 19:47:40 +0200 Maciej Fijalkowski wrote: > + if (if_running) > + ice_stop(netdev); > + if (ice_aq_set_mac_loopback(&pf->hw, ena, NULL)) > + dev_err(ice_pf_to_dev(pf), "Failed to toggle loopback state\n"); > + if (if_running) > + ice_open(netdev); Loopback or not, I don't think we should be accepting the shutdown -> set config -> pray approach in modern drivers. ice_open() seems to be allocating all the Rx memory, and can fail.
