> On Mon, Jan 17, 2022 at 06:28:29PM +0100, Lorenzo Bianconi wrote: > > + > > + CHECK(err || retval != XDP_TX || size != exp_size, > > + "9k-10b", "err %d errno %d retval %d[%d] size %d[%u]\n", > > + err, errno, retval, XDP_TX, size, exp_size); > ... > > + CHECK(err || retval != XDP_TX || size != exp_size, > > + "9k-1p", "err %d errno %d retval %d[%d] size %d[%u]\n", > > + err, errno, retval, XDP_TX, size, exp_size); > ... > > + CHECK(err || retval != XDP_TX || size != exp_size, > > + "9k-2p", "err %d errno %d retval %d[%d] size %d[%u]\n", > > + err, errno, retval, XDP_TX, size, exp_size); > > CHECK is deprecated. > That nit was mentioned many times. Please address it in all patches. I kept the CHECK macro because there were other CHECK occurrences in xdp_adjust_tail.c (e.g. in test_xdp_adjust_tail_grow()). I guess we can add a preliminary patch to convert the other CHECK occurrences used in xdp_adjust_tail.c (the same for xdp_bpf2bpf.c). What do you think? Regards, Lorenzo
Attachment:
signature.asc
Description: PGP signature
