Re: [PATCH v22 bpf-next 17/23] bpf: selftests: update xdp_adjust_tail selftest to include multi-frags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 17, 2022 at 06:28:29PM +0100, Lorenzo Bianconi wrote:
> +
> +	CHECK(err || retval != XDP_TX || size != exp_size,
> +	      "9k-10b", "err %d errno %d retval %d[%d] size %d[%u]\n",
> +	      err, errno, retval, XDP_TX, size, exp_size);
...
> +	CHECK(err || retval != XDP_TX || size != exp_size,
> +	      "9k-1p", "err %d errno %d retval %d[%d] size %d[%u]\n",
> +	      err, errno, retval, XDP_TX, size, exp_size);
...
> +	CHECK(err || retval != XDP_TX || size != exp_size,
> +	      "9k-2p", "err %d errno %d retval %d[%d] size %d[%u]\n",
> +	      err, errno, retval, XDP_TX, size, exp_size);

CHECK is deprecated.
That nit was mentioned many times. Please address it in all patches.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux