On Tue, Oct 19, 2021 at 8:23 AM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote: > > Thanks for the review. > > On 10/19/21 9:46 AM, Alexei Starovoitov wrote: > > On Thu, Oct 7, 2021 at 7:14 AM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote: > >> + > >> + sockaddr.sun_family = AF_UNIX; > >> + strcpy(sockaddr.sun_path, sock_path); > > > > please use strncpy. > > Will do. please also run checkpatch.pl and confirm you haven't introduced new styling issues. As one example (and please fix this up in the next revision), you are using C++-style comments. > > > > >> + len = sizeof(sockaddr); > >> + unlink(sock_path); > > > > please use abstract socket to avoid unlink and potential race. > > > > Will switch to abstract socket and update the BPF program.
