Re: [PATCH bpf-next 2/2 v2] selftests/bpf: Test bpf_skc_to_unix_sock() helper

[Hengqi Chen <hengqi.chen@xxxxxxxxx>]

Thanks for the review.

On 10/19/21 9:46 AM, Alexei Starovoitov wrote:
> On Thu, Oct 7, 2021 at 7:14 AM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote:
>> +
>> +       sockaddr.sun_family = AF_UNIX;
>> +       strcpy(sockaddr.sun_path, sock_path);
> 
> please use strncpy.

Will do.

> 
>> +       len = sizeof(sockaddr);
>> +       unlink(sock_path);
> 
> please use abstract socket to avoid unlink and potential race.
> 

Will switch to abstract socket and update the BPF program.