Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 12, 2021 at 12:02:11PM -0700, Andrii Nakryiko wrote:
> On Mon, May 10, 2021 at 10:09 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> >
> > On Mon, May 10, 2021 at 11:00:29AM -0700, Andrii Nakryiko wrote:
> > > On Mon, May 10, 2021 at 5:43 AM Zhen Lei <thunder.leizhen@xxxxxxxxxx> wrote:
> > > >
> > > > The result of an expression consisting of a single relational operator is
> > > > already of the bool type and does not need to be evaluated explicitly.
> > > >
> > > > No functional change.
> > > >
> > > > Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> > > > ---
> > >
> > > See [0] and [1].
> > >
> > >   [0] https://lore.kernel.org/bpf/CAEf4BzYgLf5g3oztbA-CJR4gQ7AVKQAGrsHWCOgTtUMUM-Mxfg@xxxxxxxxxxxxxx/
> > >   [1] https://lore.kernel.org/bpf/CAEf4BzZQ6=-h3g1duXFwDLr92z7nE6ajv8Rz_Zv=qx=-F3sRVA@xxxxxxxxxxxxxx/
> >
> > How long do you plan to fight with such patches?
> 
> As long as necessary. There are better ways to contribute to libbpf
> than doing cosmetic changes to the perfectly correct code.

I wish you good luck with that.

My hope that, you have enough spare time to invest in rejects.

Thanks



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux