On Wed, Apr 01, 2020 at 12:24:46AM +0300, Slava Bacherikov wrote: > 31.03.2020 23:23, Andrii Nakryiko пишет: > > On Tue, Mar 31, 2020 at 12:58 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > >> Sure! That'd by fine by me. I'd just like it to be a "|| COMPILE_TEST" > >> for GCC_PLUGIN_RANDSTRUCT. Feel free to CC me for an Ack. :) > >> > > > > +cc Slava > > > > I'm unsure what COMPILE_TEST dependency (or is it anti-dependency?) > > has to do with BTF generation and reading description in Kconfig > > didn't clarify it for me. Can you please elaborate just a bit? Thanks! > > > >> -Kees > > Hi, > > Regarding COMPILE_TEST, DEBUG_INFO has dependency on: > > DEBUG_KERNEL && !COMPILE_TEST > > And DEBUG_INFO_BTF depends on DEBUG_INFO, so enabling COMPILE_TEST > would block DEBUG_INFO and so DEBUG_INFO_BTF as well. Unless I don't > understand something and there is some other reason to add it. I meant that if you're adjusting the depends for GCC_PLUGIN_RANDSTRUCT, I'd like it to be: depends on COMPILE_TEST || !DEBUG_INFO That way randconfig, all*config, etc, will still select GCC_PLUGIN_RANDSTRUCT with everything else, regardless of DEBUG_INFO. -- Kees Cook
