On Thu, Nov 14, 2024 at 4:34 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > On Thu, 2024-11-14 at 16:27 -0800, Alexei Starovoitov wrote: > > [...] > > > Well, I asked whether it makes a difference. > > And looks like your numbers show that this optimization adds 101m to 116m ? > > No, it does not make a difference for dynptr_slice: Then let's not do it. If there is no observable performance difference there is no need to do it just to make selftests shorter. > > > - The patches #1,2 with opt_hard_wire_dead_code_branches() changes are > > > not necessary for dynptr_slice kfunc inlining / branch removal. > > > I will drop these patches and adjust test cases. > > The 101m -> 116m is for inlining w/o known branch removal -> inlining with branch removal. > (With 76m being no inlining at all). Not following. Which patch # does branch removal then?
