On Thu, Nov 14, 2024 at 4:20 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > On Thu, 2024-11-14 at 16:17 -0800, Andrii Nakryiko wrote: > > [...] > > > This true/false logic seems generally useful not just for this use > > case, is there anything wrong with landing it? Seems pretty > > straightforward. I'd split it from the kfunc inlining and land > > independently. > > I don't see anything wrong with it, but Alexei didn't like it. > Agree with your comment about organizing flags as bit-fields. Well, I asked whether it makes a difference. And looks like your numbers show that this optimization adds 101m to 116m ? If so, it's worth doing. I still don't like two bool flags though.