On Tue, Dec 17, 2019 at 7:05 PM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Tue, Dec 17, 2019 at 03:00:38PM -0800, Andrii Nakryiko wrote: > > Add bpftool-gen.rst describing skeleton on the high level. Also include > > a small, but complete, example BPF app (BPF side, userspace side, generated > > skeleton) in example section to demonstrate skeleton API and its usage. > > > > Acked-by: Yonghong Song <yhs@xxxxxx> > > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > > --- > > .../bpf/bpftool/Documentation/bpftool-gen.rst | 302 ++++++++++++++++++ > > Please test it more thoroughly. > > GEN bpftool-gen.8 > bpftool-gen.rst:244: (ERROR/3) Unexpected indentation. > bpftool-gen.rst:285: (ERROR/3) Unexpected indentation. yep, my bad, didn't realize there is Makefile I'm supposed to run... Fixed those two errors, reStructuredText is strict about code blocks. > > Patch 1 probably needs foo(void) instead of just foo(). > I think some compilers warn on it. > Added. Also simplified xxx__create_skeleton() a bit.
