Re: [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2019 at 03:00:38PM -0800, Andrii Nakryiko wrote:
> Add bpftool-gen.rst describing skeleton on the high level. Also include
> a small, but complete, example BPF app (BPF side, userspace side, generated
> skeleton) in example section to demonstrate skeleton API and its usage.
> 
> Acked-by: Yonghong Song <yhs@xxxxxx>
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
> ---
>  .../bpf/bpftool/Documentation/bpftool-gen.rst | 302 ++++++++++++++++++

Please test it more thoroughly.

  GEN      bpftool-gen.8
bpftool-gen.rst:244: (ERROR/3) Unexpected indentation.
bpftool-gen.rst:285: (ERROR/3) Unexpected indentation.

Patch 1 probably needs foo(void) instead of just foo().
I think some compilers warn on it.




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux