On Fri, 2023-12-01 at 11:26 -0800, Andrii Nakryiko wrote: > > [...] > > > > Nit: the log is not printed if verbose tests execution is requested. > > > > > > I'm not sure I understand. What do you expect to happen that's not > > > happening in verbose mode? > > > > I tried running this test -vvv and it did not print verification log > > (admittedly this is the case with many tests in prog_tests/*.c). > > I think that's the test_loader.c feature, plus maybe some other tests > support this. This is not expected to magically work for all tests. > But also in this case we explicitly intercept the log, so it would be > too much trouble to both intercept and print it at the same time, IMO. > But if this assertion fails, we'll see the log, which is the most > important part. Also one can use veristat to get the log. Well, yes, that was the point of my rumbling. When it's necessary to debug some such test one needs to modify it to use *_opts() load variant etc. Veristat makes sense, however, so not an issue. > > > > Nit/question: > > > > Why change prototype from (void) to (int) here and elsewhere? > > > > Does not seem necessary for test logic. > > > > > > I had some troubles attaching freplace initially, but my freplace > > > skills were rusty :) I can try undoing this and leaving it as is. > > > > No strong opinion, just curious. > > I undid it, it all works now. As I said, I had freplace troubles and > was poking around with different aspects. Thank you.
