On Fri, 2023-12-01 at 11:17 -0800, Andrii Nakryiko wrote: [...] > > Acked-by: Eduard Zingerman <eddyz87@xxxxxxxxx> > > Oops, didn't see your reply before sending v2. But there will be v3 anyway :) np [...] > > Nit: the log is not printed if verbose tests execution is requested. > > I'm not sure I understand. What do you expect to happen that's not > happening in verbose mode? I tried running this test -vvv and it did not print verification log (admittedly this is the case with many tests in prog_tests/*.c). [...] > > Nit/question: > > Why change prototype from (void) to (int) here and elsewhere? > > Does not seem necessary for test logic. > > I had some troubles attaching freplace initially, but my freplace > skills were rusty :) I can try undoing this and leaving it as is. No strong opinion, just curious.
