Re: [PATCH] Implement an offset option for vbladed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ed Cashin wrote...

> I was thinking of something like this:
> 
>   https://github.com/ecashin/vblade/commit/ca2dbda0a35ba686c0ed64e109748129c510fa90
> 
> Please let me know if that looks OK to you.

Looks good. One final remark, rather nitpicking. You deny length == 0
which is the right thing. It is however possible to create a zero
size export by setting offset to the size of the exported file, and a
change comparison "size <= offset" would catch that.

By the way, the initiator, at least if it's a recent Linux kernel, is 
not very impressed by such a device.

    Christoph

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Aoetools-discuss mailing list
Aoetools-discuss@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/aoetools-discuss




[Index of Archives]     [Linux ARM Kernel]     [Linux SCSI]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux