Re: [PATCH] Implement an offset option for vbladed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ed Cashin wrote...

> Thanks.  This looks interesting.  I like the way you provided a
> detailed explanation of the motivation for the patch.

You're welcome.

> Do you agree that the offset should be a vlong so that it can
> support the same large values that the size can support?  An
> unsigned int sometimes isn't going to be 64 bits.

You're totally right, and I should have done so in the first place.
Using unsigned might cause trouble when you expect it the least, and
there's also no reason to limit the offset to 2 TiB.

Related, I was asked in private whether to add another option to limit
the length of the export. While personally I have no use for that[1],
other people might see the need. The patch should be really simple.

    Christoph

[1] The legacy Linux softraid version 0.90 has its magic at the end
    of the disk.

------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Aoetools-discuss mailing list
Aoetools-discuss@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/aoetools-discuss




[Index of Archives]     [Linux ARM Kernel]     [Linux SCSI]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux