Re: [PATCH] Implement an offset option for vbladed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On May 19, 2014, at 6:46 PM, Christoph Biedl <sourceforge.bnwi@xxxxxxxxxxxxxxxxxx> wrote:

> Ed Cashin wrote...
> 
>> ... but noticed along the way that you're using atoi.  Because
>> you're supporting 64-bit numbers, would you mind sending a patch
>> that uses strtoll or doing it in git and sending a pull request?
> 
> So, version 3 then. I have some issues with github so let's better
> stay on patches, at least as long the changes are that small. This is
> based on commit baa96be.

I could talk to you about the github issues off list if you like.

Yes, I suggested strtoll because it is portable, has error checking, and supports non-decimal bases, which can be convenient, beyond the primary reason that it supports 64-bit values.

I was thinking of something like this:

  https://github.com/ecashin/vblade/commit/ca2dbda0a35ba686c0ed64e109748129c510fa90

Please let me know if that looks OK to you.

I added a subsequent commit to update the usage string, which we missed before.

  https://github.com/ecashin/vblade/commit/82b5e1ed82e5c044b75409fcee91502f1a2498ec

... and both these commits follow some long-overdue documentation updates.  The README should have mentioned the vblade's design principle of minimalism from day one.

  https://github.com/ecashin/vblade/commit/b9fb6b7c766c07de3a645599f43ab4c3190631ee

-- 
  Ed


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Aoetools-discuss mailing list
Aoetools-discuss@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/aoetools-discuss




[Index of Archives]     [Linux ARM Kernel]     [Linux SCSI]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux