Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

["Lazar, Lijo" <Lijo.Lazar@xxxxxxx>]

[Public]

Ya, second is too lengthy.  Better to leave it as it is.

BTW, is this specific to reset by BACO? BACO entry/exit may take longer (better chance of suspend entry abort by some wake-up source).

Thanks,
Lijo

---

From: Limonciello, Mario <Mario.Limonciello@xxxxxxx>
Sent: Tuesday, May 17, 2022 10:00:16 PM
To: Lazar, Lijo <Lijo.Lazar@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Subject: RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

 

[Public]

 

> PM_SUSPEND_TO_IDLE should be under a compile guard

 

It is actually.  All of the amdgpu_acpi_* are.  It’s not obvious though looking at the patch, you need to apply it to notice it.

 

> It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.

 

Remember it’s in amdgpu_acpi.c.  So it would be amdgpu_acpi_need_reset_on_suspend()?  It’s a bit lengthy.

 

From: Lazar, Lijo <Lijo.Lazar@xxxxxxx>
Sent: Tuesday, May 17, 2022 11:25
To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Limonciello, Mario <Mario.Limonciello@xxxxxxx>
Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

 

[Public]

 

A couple of things -

 

PM_SUSPEND_TO_IDLE should be under a compile guard

 

It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.

 

Thanks,
Lijo