[Public] > PM_SUSPEND_TO_IDLE should be under a compile guard It is actually. All of the amdgpu_acpi_* are. It’s not obvious though looking at the patch, you need to apply it to notice it. > It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation. Remember it’s in amdgpu_acpi.c. So it would be amdgpu_acpi_need_reset_on_suspend()? It’s a bit lengthy. From: Lazar, Lijo <Lijo.Lazar@xxxxxxx> [Public] A couple of things - PM_SUSPEND_TO_IDLE should be under a compile guard It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation. Thanks, |