Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

To: "Limonciello, Mario" <Mario.Limonciello@xxxxxxx>, "amd-gfx@xxxxxxxxxxxxxxxxxxxxx" <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle
From: "Lazar, Lijo" <Lijo.Lazar@xxxxxxx>
Date: Tue, 17 May 2022 16:25:05 +0000
Accept-language: en-US
Cc: "Limonciello, Mario" <Mario.Limonciello@xxxxxxx>
In-reply-to: <20220517133944.25612-1-mario.limonciello@amd.com>
Msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=True; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-05-17T16:22:28.7666430Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged
References: <20220517133944.25612-1-mario.limonciello@amd.com>

[Public]

A couple of things -

PM_SUSPEND_TO_IDLE should be under a compile guard

It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.

Thanks,
Lijo

Follow-Ups:
- RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle
  - From: Limonciello, Mario

References:
- [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle
  - From: Mario Limonciello