Thanks Alex, That's fine for me. Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com> Regards, Jerry (Junwei Zhang) Linux Base Graphics SRDC Software Development _____________________________________ From: Deucher, Alexander Sent: Wednesday, January 17, 2018 22:12 To: Zhang, Jerry; amd-gfx at lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: disable ECC check for Raven to avoid error message annoyance The check should be moved up into late_init where the call to ecc_available is and we should make it explicit since only vega10 supports it, that way we don't get any false messages from RV. How about the attached patch? Alex ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx<mailto:amd-gfx-bounces at lists.freedesktop.org>> on behalf of Junwei Zhang <Jerry.Zhang at amd.com<mailto:Jerry.Zhang at amd.com>> Sent: Wednesday, January 17, 2018 2:02 AM To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> Cc: Zhang, Jerry Subject: [PATCH] drm/amdgpu: disable ECC check for Raven to avoid error message annoyance It should be enabled until ECC is supported for Raven. Change-Id: If847663d503c26d2a08274ca721b4ce1bc637111 Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com<mailto:Jerry.Zhang at amd.com>> --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index c12ee75..a333442 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c @@ -533,6 +533,10 @@ static int gmc_v9_0_ecc_available(struct amdgpu_device *adev) DRM_DEBUG("ecc: gmc_v9_0_ecc_available()\n"); + /* Temporally skip ECC for Raven to avoid error message annoyance */ + if (adev->asic_type == CHIP_RAVEN) + return 0; + lost_sheep = 0; for (i = 0; i < ARRAY_SIZE(ecc_umclocalcap_addrs); ++i) { reg_addr = ecc_umclocalcap_addrs[i]; -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180118/951d536b/attachment-0001.html>
