Reviewed-by: Rex Zhu <Rex.Zhu at amd.com> Best Regards Rex From: Deucher, Alexander Sent: Thursday, January 18, 2018 7:11 AM To: Grodzovsky, Andrey; amd-gfx at lists.freedesktop.org Cc: Lipski, Mikita; Zhu, Rex Subject: Re: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type Reviewed-by: Alex Deucher <alexander.deucher at amd.com<mailto:alexander.deucher at amd.com>> ________________________________ From: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx<mailto:andrey.grodzovsky at amd.com>> Sent: Wednesday, January 17, 2018 5:35 PM To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> Cc: Lipski, Mikita; Zhu, Rex; Deucher, Alexander; Grodzovsky, Andrey Subject: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type Handle describes kernel logical address, should be unsigned long and not uint32_t. Fixes KASAN error and GFP on driver unload. Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com<mailto:andrey.grodzovsky at amd.com>> --- drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h b/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h index 5888840..caebdbe 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h +++ b/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h @@ -40,7 +40,7 @@ struct smu_table_entry { uint32_t table_addr_high; uint32_t table_addr_low; uint8_t *table; - uint32_t handle; + unsigned long handle; }; struct smu_table_array { -- 2.7.4 -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180118/ad2db9a4/attachment-0001.html>
