On Mon, 2018-01-01 at 16:12 -0500, Alex Deucher wrote: > On Thu, Dec 21, 2017 at 5:04 AM, Dmitry Rozhkov > <dmitry.rozhkov at linux.intel.com> wrote: > > printk format strings accepting a single subsequent argument > > are shorter thus easier to read. > > I'm not sure I agree it's easier to read. > IMHO, it's somewhat less > clear what's going on, If you check how many times %*ph is used in the kernel... Or then you may concern about entire bunch of %p extensions in the kernel. Anyway, main rationale I think is a stack use and performance. But it's still about debug messages in this case, and in particular only about 3 bytes (btw, if needed it might be easily expanded for up to 64 bytes or even with run-time adjusted length). > but I don't have a particularly strong opinion > either way. Applied. Thanks. -- Andy Shevchenko <andriy.shevchenko at linux.intel.com> Intel Finland Oy
