On Thu, Dec 21, 2017 at 5:04 AM, Dmitry Rozhkov
<dmitry.rozhkov at linux.intel.com> wrote:
> printk format strings accepting a single subsequent argument
> are shorter thus easier to read.
I'm not sure I agree it's easier to read. IMHO, it's somewhat less
clear what's going on, but I don't have a particularly strong opinion
either way. Applied.
Thanks,
Alex
>
> Instead of having format strings accepting 3 different arguments
> pointing to first 3 bytes of the same buffer rewrite the format
> string to accept only one argument - the buffer - with "%3ph"
> specifier.
>
> Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov at linux.intel.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
> drivers/gpu/drm/radeon/radeon_dp_mst.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> index 183b4b482138..ca2bcfb32935 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> @@ -718,7 +718,7 @@ radeon_dp_mst_check_status(struct radeon_connector *radeon_connector)
> DP_SINK_COUNT_ESI, esi, 8);
> go_again:
> if (dret == 8) {
> - DRM_DEBUG_KMS("got esi %02x %02x %02x\n", esi[0], esi[1], esi[2]);
> + DRM_DEBUG_KMS("got esi %3ph\n", esi);
> ret = drm_dp_mst_hpd_irq(&radeon_connector->mst_mgr, esi, &handled);
>
> if (handled) {
> @@ -733,7 +733,7 @@ radeon_dp_mst_check_status(struct radeon_connector *radeon_connector)
> dret = drm_dp_dpcd_read(&radeon_connector->ddc_bus->aux,
> DP_SINK_COUNT_ESI, esi, 8);
> if (dret == 8) {
> - DRM_DEBUG_KMS("got esi2 %02x %02x %02x\n", esi[0], esi[1], esi[2]);
> + DRM_DEBUG_KMS("got esi2 %3ph\n", esi);
> goto go_again;
> }
> } else
> --
> 2.13.6
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
