On Fri, Jun 23, 2017 at 01:05:37PM -0400, Alex Deucher wrote: > On Fri, Jun 23, 2017 at 12:43 PM, Christian König > > Have the painkillers jellyfied my brain or are you setting a pointer in the > > amdgpu device structure to some variable on the stack? > > If it's just for initialization then that's probably ok, but I would reset > > the pointer at the end of the function. > > Otherwise somebody might have the idea to dereference it later on and that > > can only lead to trouble. > I think it's ok because the hotplug of the audio device is triggered > from this function, so the audio device should be probed by the time > this variable goes out of scope. That said, it would probably be No, that's in no way safe. There is no guarantee that probe is going to happen on any particular schedule, if the other driver isn't registered yet it'll need to wait for that to happen for example. You will often get away with it but that's at best going to be vulnerable to framework changes (what if someone decides to kick off the probe on a separate CPU in an effort to reduce boot time?). > better to use the asic_type from the GPU driver instance directly > rather than a stack variable. Yes. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170628/e5a1061c/attachment.sig>
