On Fri, Jun 23, 2017 at 12:35:01PM -0400, Alex Deucher wrote: > + if (adev->asic_type == CHIP_STONEY) { > + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET | > + DW_I2S_QUIRK_COMP_PARAM1 | > + DW_I2S_QUIRK_16BIT_IDX_OVERRIDE; > + } else { > + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET | > + DW_I2S_QUIRK_COMP_PARAM1; > + } Quirks like this are better written as switch statements since that makes it easier to handle further variants in future. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170628/4b4d88d8/attachment.sig>