On Fri, 2017-08-25 at 14:11 +0100, Mark Brown wrote: > On Thu, Aug 24, 2017 at 06:11:12PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > But the id table is already empty...? > > > Right, that seems like a bug though. > > Well, that's what the commit ddc9e69b9dc2 does after all: it cleans > > up > > the legacy usage, and moves all either OF or ACPI matching. > > Which is broken since not all the world is ACPI or DT. While I agree on the second part, I don't think it's broken per se, there never was a single user of that, and looking how ASoC board files are organized it is quite unlikely there will be one... > > If we want to take back old i2c ids, better to put the explicit > > i2c_match_id() check in rt5677_i2c_probe() instead of sticking with > > the old i2c probe callback. > > That's what I said, yes. ...though we can (re)introduce this dead code back for a potential user in the future. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
